Handle error response codes to HTTP requests. #61

igorpeshansky · 2018-02-25T05:36:31Z

Depends on #59, but will rebase and merge to master once that's in.

supriyagarg

The changes look good. However, the watch response in kubernetes.cc (L750) and the oauth response in oauth2.cc (L238) don't have the error handling code.

igorpeshansky · 2018-02-26T01:51:55Z

Thanks for the review. I've added the handling in oauth2.cc.
Unfortunately, there doesn't seem to be a way to do this in the watch code (streaming HTTP), as the cpp-netlib library doesn't support that. I'll bring it up with the upstream maintainers.
PTAL.

igorpeshansky · 2018-02-26T02:12:33Z

Rebased off master.

supriyagarg

LGTM

bmoyles0117 · 2018-02-26T05:37:17Z

src/api_server.cc

+        LOG(INFO) << "Metadata request sent successfully";
+      }
+    } catch (const boost::system::system_error& e) {
+      LOG(ERROR) << "Unsuccessful: " << e.what();


s/Unsuccessful/Metadata request unsuccessful/

bmoyles0117 · 2018-02-26T05:38:02Z

src/api_server.cc

@@ -204,6 +210,13 @@ void SendMetadataRequest(std::vector<json::value>&& entries,
  request << boost::network::header("Authorization", auth_header);
  request << boost::network::body(request_body);
  http::client::response response = client.post(request);
+  if (status(response) != 200) {
+    throw boost::system::system_error(
+        boost::system::errc::make_error_code(boost::system::errc::not_connected),


I don't believe not_connected is the best exception to throw here, but if it's just a matter of getting "something" to throw, it's fine.

Yes, that code is never examined.

bmoyles0117 · 2018-02-26T05:39:02Z

src/api_server.cc

@@ -204,6 +210,13 @@ void SendMetadataRequest(std::vector<json::value>&& entries,
  request << boost::network::header("Authorization", auth_header);
  request << boost::network::body(request_body);
  http::client::response response = client.post(request);
+  if (status(response) != 200) {


I would accept anything in the 2xx range, technically a POST can result in a 201 Created. Applies to other posts as well. I'm sure it's not our contract with the resource metadata api yet, but just something to be mindful of.

bmoyles0117 · 2018-02-26T05:40:22Z

src/docker.cc

@@ -169,6 +170,13 @@ json::value DockerReader::QueryDocker(const std::string& path) const
  }
  try {
    http::local_client::response response = client.get(request);
+    if (status(response) != 200) {


Just as a note, I'm fine with just a 200 here as you have it.

Changed for consistency.

bmoyles0117 · 2018-02-26T05:41:45Z

src/format.cc

@@ -20,6 +20,19 @@

 namespace format {

+namespace {
+template<class T>
+std::string AsString(T v) {


I don't see this being used anywhere.

Lines 32-34 below.

Well, my eyes certainly failed me 🤣

igorpeshansky

Addressed feedback. PTAL.

igorpeshansky · 2018-02-26T06:13:19Z

src/api_server.cc

+        LOG(INFO) << "Metadata request sent successfully";
+      }
+    } catch (const boost::system::system_error& e) {
+      LOG(ERROR) << "Unsuccessful: " << e.what();


igorpeshansky · 2018-02-26T06:13:36Z

src/api_server.cc

@@ -204,6 +210,13 @@ void SendMetadataRequest(std::vector<json::value>&& entries,
  request << boost::network::header("Authorization", auth_header);
  request << boost::network::body(request_body);
  http::client::response response = client.post(request);
+  if (status(response) != 200) {


igorpeshansky · 2018-02-26T06:14:06Z

src/api_server.cc

@@ -204,6 +210,13 @@ void SendMetadataRequest(std::vector<json::value>&& entries,
  request << boost::network::header("Authorization", auth_header);
  request << boost::network::body(request_body);
  http::client::response response = client.post(request);
+  if (status(response) != 200) {
+    throw boost::system::system_error(
+        boost::system::errc::make_error_code(boost::system::errc::not_connected),


Yes, that code is never examined.

igorpeshansky · 2018-02-26T06:14:21Z

src/docker.cc

@@ -169,6 +170,13 @@ json::value DockerReader::QueryDocker(const std::string& path) const
  }
  try {
    http::local_client::response response = client.get(request);
+    if (status(response) != 200) {


Changed for consistency.

igorpeshansky · 2018-02-26T06:14:39Z

src/format.cc

@@ -20,6 +20,19 @@

 namespace format {

+namespace {
+template<class T>
+std::string AsString(T v) {


Lines 32-34 below.

bmoyles0117

LGTM

igorpeshansky requested review from bmoyles0117 and supriyagarg February 25, 2018 05:36

supriyagarg suggested changes Feb 26, 2018

View reviewed changes

igorpeshansky added 2 commits February 25, 2018 21:11

Handle error response codes to HTTP requests.

2785388

Handle HTTP response codes in the OAuth code.

32e3db1

igorpeshansky force-pushed the igorp-handle-http-codes branch from 7bc2c05 to 32e3db1 Compare February 26, 2018 02:11

igorpeshansky changed the base branch from igorp-docker-instance-id to master February 26, 2018 02:12

supriyagarg approved these changes Feb 26, 2018

View reviewed changes

bmoyles0117 suggested changes Feb 26, 2018

View reviewed changes

Handle more codes; error tweaks.

b64acd4

igorpeshansky force-pushed the igorp-handle-http-codes branch from 03e04f2 to b64acd4 Compare February 26, 2018 06:13

igorpeshansky commented Feb 26, 2018

View reviewed changes

bmoyles0117 approved these changes Feb 26, 2018

View reviewed changes

igorpeshansky merged commit 5a459be into master Feb 26, 2018

igorpeshansky deleted the igorp-handle-http-codes branch March 3, 2018 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle error response codes to HTTP requests. #61

Handle error response codes to HTTP requests. #61

igorpeshansky commented Feb 25, 2018 •

edited

Loading

supriyagarg left a comment

igorpeshansky commented Feb 26, 2018

igorpeshansky commented Feb 26, 2018

supriyagarg left a comment

bmoyles0117 Feb 26, 2018

igorpeshansky Feb 26, 2018

bmoyles0117 Feb 26, 2018

igorpeshansky Feb 26, 2018

bmoyles0117 Feb 26, 2018

igorpeshansky Feb 26, 2018

bmoyles0117 Feb 26, 2018

igorpeshansky Feb 26, 2018

bmoyles0117 Feb 26, 2018

igorpeshansky Feb 26, 2018

bmoyles0117 Feb 26, 2018

igorpeshansky left a comment

igorpeshansky Feb 26, 2018

igorpeshansky Feb 26, 2018

igorpeshansky Feb 26, 2018

igorpeshansky Feb 26, 2018

igorpeshansky Feb 26, 2018

bmoyles0117 left a comment

Handle error response codes to HTTP requests. #61

Handle error response codes to HTTP requests. #61

Conversation

igorpeshansky commented Feb 25, 2018 • edited Loading

supriyagarg left a comment

Choose a reason for hiding this comment

igorpeshansky commented Feb 26, 2018

igorpeshansky commented Feb 26, 2018

supriyagarg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

igorpeshansky left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmoyles0117 left a comment

Choose a reason for hiding this comment

igorpeshansky commented Feb 25, 2018 •

edited

Loading