This repository has been archived by the owner on Aug 19, 2019. It is now read-only.
Set Content-Length when writing responses to close client connections. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorpeshansky
suggested changes
Jul 22, 2018
src/api_server.cc
Outdated
|
|
||
| std::string response = "unhealthy components:\n"; | ||
| for (const auto& component : unhealthy_components) { | ||
| response.append(component + "\n"); |
There was a problem hiding this comment.
Let's use std::ostringstrean instead of std::string::append.
There was a problem hiding this comment.
Updated, but I'll link to this for context:
https://stackoverflow.com/questions/905479/stdstring-length-and-size-member-functions
src/api_server.cc
Outdated
| conn->set_headers(std::map<std::string, std::string>({ | ||
| {"Content-Type", "application/json"}, | ||
| {"Content-Length", std::to_string(response.length())}, |
There was a problem hiding this comment.
I believe we use std::string::size everywhere else...
igorpeshansky
approved these changes
Jul 22, 2018
src/api_server.cc
Outdated
| } else { | ||
| LOG(WARNING) << "/healthz returning 500; unhealthy components: " | ||
| << boost::algorithm::join(unhealthy_components, ", "); | ||
| conn->set_status(HttpServer::connection::internal_server_error); | ||
|
|
||
| std::ostringstream response_stream; | ||
| response_stream << "unhealthy components:\n"; |
There was a problem hiding this comment.
[Optional] You can combine these:
std::ostringstream response_stream("unhealthy components:\n");
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.