-
-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official support for python 3.10 and 3.11 #6292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a bunch of annotations that have been showing up in CI. I finally found the source of that warning.
And harmonize the start version by copying the flake8 minimum.
…lake8 --resolve=pylint --resolve=twine This also copies the pylint upgrade into test-requirements.txt. Lockfile diff: lockfiles/black.lock [black] == Upgraded dependencies == platformdirs 4.2.0 --> 4.3.6 tomli 2.0.1 --> 2.2.1 typing-extensions 4.10.0 --> 4.12.2 Lockfile diff: lockfiles/pylint.lock [pylint] == Upgraded dependencies == dill 0.3.8 --> 0.3.9 platformdirs 4.2.1 --> 4.3.6 pylint 3.1.0 --> 3.1.1 setuptools 69.5.1 --> 75.3.0 tomli 2.0.1 --> 2.2.1 tomlkit 0.12.4 --> 0.13.2 typing-extensions 4.11.0 --> 4.12.2 Lockfile diff: lockfiles/bandit.lock [bandit] == Upgraded dependencies == rich 13.9.3 --> 13.9.4 setuptools 75.2.0 --> 75.3.0 Lockfile diff: lockfiles/flake8.lock [flake8] == Upgraded dependencies == setuptools 75.2.0 --> 75.3.0 Lockfile diff: lockfiles/twine.lock [twine] == Upgraded dependencies == certifi 2024.2.2 --> 2024.12.14 cffi 1.16.0 --> 1.17.1 charset-normalizer 3.3.2 --> 3.4.0 cryptography 42.0.5 --> 43.0.3 idna 3.6 --> 3.10 importlib-metadata 7.1.0 --> 8.5.0 importlib-resources 6.4.0 --> 6.4.5 jaraco-context 4.3.0 --> 6.0.1 jaraco-functools 4.0.0 --> 4.1.0 keyring 25.1.0 --> 25.5.0 more-itertools 10.2.0 --> 10.5.0 nh3 0.2.17 --> 0.2.20 pkginfo 1.10.0 --> 1.12.0 pygments 2.17.2 --> 2.18.0 requests 2.31.0 --> 2.32.3 tqdm 4.66.2 --> 4.67.1 urllib3 2.2.1 --> 2.2.3 zipp 3.18.1 --> 3.20.2 == Added dependencies == backports-tarfile 1.2.0
And copy the pusutil update to all requirements files. Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == psutil 6.1.0 --> 6.1.1
cognifloyd
requested review from
winem,
nzlosh,
rush-skills,
guzzijones,
amanda11 and
a team
December 19, 2024 22:11
pull-request-size
bot
added
the
size/XXL
PR that changes 1000+ lines. You should absolutely split your PR into several.
label
Dec 19, 2024
cognifloyd
force-pushed
the
py3.10
branch
2 times, most recently
from
December 19, 2024 23:29
4a28d5c
to
96925a7
Compare
nzlosh
approved these changes
Dec 20, 2024
guzzijones
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
external dependency
feature
infrastructure: ci/cd
maintenance
pantsbuild
size/XXL
PR that changes 1000+ lines. You should absolutely split your PR into several.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks commits from #6236 by @nzlosh and @guzzijones.
This adds python 3.10 and 3.11 to:
The vast number of additional tests in our test matrix made it difficult to ensure we included the new python versions everywhere required. So, I refactored the
matrix
in each workflow to let GitHub handle expanding the matrix for us.While I was in the GHA workflows I noticed a couple of minor issues, so I fixed those as well:
.github/actions/setup-python
that was causing a lot of warnings to be listed under GHA annotations.on.pull_request.type
withon.pull_request.types
. "type" is not a valid key, so our workflows have just been using the default list of events:opened, reopened, synchronize
. So, I used that as well. If someone wants to addedited
later, that's fine--just know that there will be downsides because editing the PR description or name will retrigger CI.I also had to bump the
pre-commit
andpre-commit-hooks
version as it was raising an error on python3.11.Lockfile Diffs