Skip to content

Commit

Permalink
Fix typos and Clean comments
Browse files Browse the repository at this point in the history
  • Loading branch information
piroux-sg committed Mar 11, 2024
1 parent 22883dc commit efddeb7
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
9 changes: 0 additions & 9 deletions internal/provider/api_object.go
Original file line number Diff line number Diff line change
Expand Up @@ -307,15 +307,6 @@ func (obj *api_object) read_object_from_listall() error {
return err
}

/*
TODO:
- Unmarshal
- Find data msg key
- Iterate over array of Secrets
- Create internal limited secret struct if it finds the ResourceName -- needed if no update ?
- No update of the state
*/

type secretListAllResponse struct {
Msg []struct {
ResourceName string `json:"ResourceName"`
Expand Down
2 changes: 0 additions & 2 deletions internal/provider/secret_object.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
)

func resourceStackGuardianSecretAPI() *schema.Resource {
// Consider data sensitive if env variables is set to true.
is_data_sensitive := true

return &schema.Resource{
Expand Down Expand Up @@ -199,7 +198,6 @@ func make_api_object_secret(d *schema.ResourceData, meta interface{}) (*api_obje
}

func buildApiObjectSecretOpts(d *schema.ResourceData) (*apiObjectOpts, error) {
// resultPath := "/wfgrps/" + d.Get("wfgrp").(string) + "/stacks/"
resultPath := "/secrets/"

opts := &apiObjectOpts{
Expand Down
3 changes: 0 additions & 3 deletions internal/provider/secret_object_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ resource "stackguardian_secret" "TPS-Test-Secret-Name" {
`

func TestAcc_ResourceSgSecret(t *testing.T) {
//t.Skipf("TODO: Fix DELETE: deletion of Secret resource is not possible with API Key")
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
Expand All @@ -30,8 +29,6 @@ func TestAcc_ResourceSgSecret(t *testing.T) {
"TPS-Test-Secret-Name",
),
),
//Destroy: true,
//PreventPostDestroyRefresh: true,
},
},
})
Expand Down

0 comments on commit efddeb7

Please sign in to comment.