Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.0 #185

Merged
merged 4 commits into from
Mar 15, 2017
Merged

Release v1.2.0 #185

merged 4 commits into from
Mar 15, 2017

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Mar 12, 2017

  • Upgrade Python packages in case the requirements have changed during package upgrades
  • Split test dependencies since there is no need to install the test dependencies on a production system
  • Upgrade dependencies
  • Bump version to v1.2.0

@mprahl
Copy link
Member Author

mprahl commented Mar 13, 2017

@thatarchguy I'll fix the tests tonight. I forgot to modify the travis file.

I was thinking that the test-requirements probably don't need to have versions pinned, so I could delete the test-requirements.txt file and rename test-requirements.in to test-requirements.txt.

What are your thoughts?

@thatarchguy
Copy link
Member

I was thinking that the test-requirements probably don't need to have versions pinned, so I could delete the test-requirements.txt file and rename test-requirements.in to test-requirements.txt.

If we are splitting off the test requirements, then yeah pop it off unpinned to a .txt file for simplicity. I don't believe we should be compiling our test requirements separately.

Another pattern I've seen that I don't know if I'm fond of yet is

requirements/
    ./common.txt
    ./dev.txt

with ./dev containing -r common.txt so you don't need multiple pip install declarations.

@mprahl
Copy link
Member Author

mprahl commented Mar 14, 2017

@thatarchguy I had to make some changes based on some breaking changes from passlib and a deprecation warning from flask-wtf, but it should be good to go now.

@@ -4,14 +4,14 @@
Purpose: form definitions for the app
"""

from flask_wtf import Form
from flask_wtf import FlaskForm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@thatarchguy thatarchguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the passlib and flask-wtf changes

@thatarchguy thatarchguy merged commit e80a06a into master Mar 15, 2017
@mprahl mprahl deleted the 1.2 branch March 15, 2017 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants