fix(tooltip): resolve accessibility issues #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially resolves issues in StackEng/StackOverflow#12658 (comment)
You may ask "why keyup and not keydown". The keydown event occurs repeatedly when a key is held down, which results in the listener function being executed repeatedly and unnecessarily. Keyup only fires once per keypress.
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dancormier
added a commit
that referenced
this pull request
Aug 30, 2022
* 1.3.0 * build(dependencies): update stacks-editor and stacks-icons dependencies * build(deps-dev): bump webpack from 5.73.0 to 5.74.0 (#1044) Bumps [webpack](https://github.com/webpack/webpack) from 5.73.0 to 5.74.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.73.0...v5.74.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor(eslint): fix controller eslint/typescript errors (#1009) * refactor(opacity): add --_o-disabled private CSS vars * feat: add standalone .is-readonly, .is-loading classes (#1040) * refactor(inputs): remove @basic-styling abstraction * chore(expandable): rename collapsible to expandable Only obvious name replacements made. No logic has been modified for this change. * chore(empty-states): rename blank-states to empty-states * refactor(label): move .s-label Less to standalone file (#1046) * refactor(uploader): cleanup Less; apply focus styles * docs(badges): ensure badge tables are keyboard focusable * fix(popovers): apply aria-expanded to element in DOM * docs(inputs): typo fix * build(deps-dev): bump backstopjs from 6.1.0 to 6.1.1 (#1050) Bumps [backstopjs](https://github.com/garris/backstopjs) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/garris/backstopjs/releases) - [Changelog](https://github.com/garris/BackstopJS/blob/master/changelog.md) - [Commits](https://github.com/garris/backstopjs/commits) --- updated-dependencies: - dependency-name: backstopjs dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @stackoverflow/stacks-icons from 3.0.1 to 3.0.2 (#1051) Bumps [@stackoverflow/stacks-icons](https://github.com/StackExchange/Stacks-Icons) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/StackExchange/Stacks-Icons/releases) - [Commits](StackExchange/Stacks-Icons@v3.0.1...v3.0.2) --- updated-dependencies: - dependency-name: "@stackoverflow/stacks-icons" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint from 8.20.0 to 8.22.0 (#1056) Bumps [eslint](https://github.com/eslint/eslint) from 8.20.0 to 8.22.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.20.0...v8.22.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump cssnano from 5.1.12 to 5.1.13 (#1058) Bumps [cssnano](https://github.com/cssnano/cssnano) from 5.1.12 to 5.1.13. - [Release notes](https://github.com/cssnano/cssnano/releases) - [Commits](https://github.com/cssnano/cssnano/compare/[email protected]@5.1.13) --- updated-dependencies: - dependency-name: cssnano dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump stylelint from 14.9.1 to 14.10.0 (#1060) Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.9.1 to 14.10.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@14.9.1...14.10.0) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @typescript-eslint/parser from 5.31.0 to 5.33.0 (#1059) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.31.0 to 5.33.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.33.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @popperjs/core from 2.11.5 to 2.11.6 (#1062) Bumps [@popperjs/core](https://github.com/popperjs/popper-core) from 2.11.5 to 2.11.6. - [Release notes](https://github.com/popperjs/popper-core/releases) - [Commits](floating-ui/floating-ui@v2.11.5...v2.11.6) --- updated-dependencies: - dependency-name: "@popperjs/core" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(breadcrumbs): meet WCAG 2 AA contrast (#1015) Note: contrast is judged in the context of the Stacks documentation. In this case, the breadcrumbs are within a container with a background color different from the main content background color. This may result in an overcompensation for color contrast. That said, we can look at this as a little extra reassurance that if the component is used on a different background color, it's still likely to pass accessibility checks. * Fix lingering accessibility issues found by Mabl (#1048) * docs(breadcrumbs): set role on demo h1s * docs(editor): add alt text to demo image * docs(menus): wrap fieldset in div[role="menu"] See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset#technical_summary "Permitted ARIA roles" section * docs(breadcrumbs): set role on demo h1s to presentation * docs(badges): ensure all overflow divs are scrollable * docs(navigation): ensure tabs are direct descendants of tablists * docs(popovers): ensure unique ids * docs(page-titles): set presentation role on examples * docs(popovers): set presentation role on examples * docs(prose): ensure all md images have alt attr * docs(prose): add presentation role to md examples * docs(tables): remove invalid scope attr * fix(expandable): don't add aria-expanded to radio elements See also: w3c/aria#1404 * fix(navigation): use aria-pressed on button elements * Revert "fix(navigation): use aria-pressed on button elements" This reverts commit f4f460b. * docs(navigation): add role="tab" to tablist button * docs(notice): use section for elements w/ role="status" * Revert "docs(notice): use section for elements w/ role="status"" This reverts commit ef938a5. * build(deps-dev): bump stylelint-config-recommended from 8.0.0 to 9.0.0 (#1061) Bumps [stylelint-config-recommended](https://github.com/stylelint/stylelint-config-recommended) from 8.0.0 to 9.0.0. - [Release notes](https://github.com/stylelint/stylelint-config-recommended/releases) - [Changelog](https://github.com/stylelint/stylelint-config-recommended/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint-config-recommended@8.0.0...9.0.0) --- updated-dependencies: - dependency-name: stylelint-config-recommended dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @typescript-eslint/eslint-plugin (#1057) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.31.0 to 5.33.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.33.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump stylelint-config-standard from 26.0.0 to 27.0.0 (#1063) Bumps [stylelint-config-standard](https://github.com/stylelint/stylelint-config-standard) from 26.0.0 to 27.0.0. - [Release notes](https://github.com/stylelint/stylelint-config-standard/releases) - [Changelog](https://github.com/stylelint/stylelint-config-standard/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint-config-standard@26.0.0...27.0.0) --- updated-dependencies: - dependency-name: stylelint-config-standard dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump terser-webpack-plugin from 5.3.3 to 5.3.4 (#1064) Bumps [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases) - [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/terser-webpack-plugin@v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: terser-webpack-plugin dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(progress): increase stepped label contrast * refactor(components): Merge .s-banner into .s-notice; fix a11y issues (#1022) * docs(toasts): make example order consistent * refactor(notice): Add .build-component less fn * refactor(notice): Combine banner, notice Less * fix(notice): increase danger modifier contrast * refactor(notice): adjust failing contrast variants to pass * docs(notice): add default notice example * refactor(notice): group styling by modifier * docs(banner): add .s-banner--btn documentation * Get more specific with naming (.construct-notice-component) * tweak construct-notice-component mixin Co-authored-by: Ben Kelly <[email protected]> * refactor(layout): update codepen template links * fix(pagination): add aria-current attr to selected item fixes #1054 * docs(sidebarwidgets): update example to use `h2` * build(deps-dev): bump @11ty/eleventy from 1.0.1 to 1.0.2 (#1068) Bumps [@11ty/eleventy](https://github.com/11ty/eleventy) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/11ty/eleventy/releases) - [Changelog](https://github.com/11ty/eleventy/blob/master/docs/release-instructions.md) - [Commits](11ty/eleventy@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: "@11ty/eleventy" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump stylelint from 14.10.0 to 14.11.0 (#1069) Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.10.0 to 14.11.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@14.10.0...14.11.0) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump stylelint-config-standard from 27.0.0 to 28.0.0 (#1070) Bumps [stylelint-config-standard](https://github.com/stylelint/stylelint-config-standard) from 27.0.0 to 28.0.0. - [Release notes](https://github.com/stylelint/stylelint-config-standard/releases) - [Changelog](https://github.com/stylelint/stylelint-config-standard/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint-config-standard@27.0.0...28.0.0) --- updated-dependencies: - dependency-name: stylelint-config-standard dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @typescript-eslint/eslint-plugin (#1071) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.33.0 to 5.33.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.33.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(labels): increase contrast (#1065) * refactor(components): Use component-specific custom properties (#1021) * Use custom properties for avatar sizes * whoops, math is hard * refactor(avatar): set pseudo-private properties I made my initial commits before seeing Lea Verou's talk "CSS Variable Secrets": https://www.youtube.com/watch?v=ZuZizqDF4q8&t=633s * refactor(activity-indicator): use custom properties * refactor(activity indicator): match naming convention * refactor(badges): use custom properties * Use develop badge less * Remove dupe .badge-styles less fn from topbar * docs(radio): add legend to all fieldset examples * build(deps-dev): bump @stackoverflow/stacks-icons from 3.0.2 to 3.0.4 (#1072) Bumps [@stackoverflow/stacks-icons](https://github.com/StackExchange/Stacks-Icons) from 3.0.2 to 3.0.4. - [Release notes](https://github.com/StackExchange/Stacks-Icons/releases) - [Commits](StackExchange/Stacks-Icons@v3.0.2...v3.0.4) --- updated-dependencies: - dependency-name: "@stackoverflow/stacks-icons" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Revert "build(deps-dev): bump @stackoverflow/stacks-icons from 3.0.2 to 3.0.4 (#1072)" (#1075) This reverts commit ccdd919. * docs(button-group): document aria-current attribute usage (#1066) * build(deps-dev): bump @typescript-eslint/parser from 5.33.0 to 5.34.0 (#1074) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.33.0 to 5.34.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.34.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(styles): drop deprecated `word-wrap` property (#854) According to [MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap): > The property was originally a nonstandard and unprefixed Microsoft extension called word-wrap, and was implemented by most browsers with the same name. It has since been renamed to overflow-wrap, with word-wrap being an alias. I think we can safely ditch `word-wrap` for `overflow-wrap` everywhere and save a few bytes. * fix(tooltip): resolve accessibility issues (#1078) * refactor(tooltip): don't set aria-hidden automatically Partially resolves issues in StackEng/StackOverflow#12658 (comment) * feature(tooltip): hide on escape key press You may ask "why keyup and not keydown". The keydown event occurs repeatedly when a key is held down, which results in the listener function being executed repeatedly and unnecessarily. Keyup only fires once per keypress. * remove `console.log("weeeee")` 😂 * feature(tooltip): persist tooltip on mouseover * Name function more accurately * build(deps-dev): bump typescript from 4.7.4 to 4.8.2 (#1082) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.7.4 to 4.8.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.7.4...v4.8.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @typescript-eslint/eslint-plugin (#1083) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.33.1 to 5.35.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.35.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump jquery from 3.6.0 to 3.6.1 (#1081) Bumps [jquery](https://github.com/jquery/jquery) from 3.6.0 to 3.6.1. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](jquery/jquery@3.6.0...3.6.1) --- updated-dependencies: - dependency-name: jquery dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump terser-webpack-plugin from 5.3.4 to 5.3.5 (#1080) Bumps [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) from 5.3.4 to 5.3.5. - [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases) - [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/terser-webpack-plugin@v5.3.4...v5.3.5) --- updated-dependencies: - dependency-name: terser-webpack-plugin dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint from 8.22.0 to 8.23.0 (#1085) Bumps [eslint](https://github.com/eslint/eslint) from 8.22.0 to 8.23.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.22.0...v8.23.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @typescript-eslint/parser from 5.34.0 to 5.35.1 (#1084) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.34.0 to 5.35.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.35.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): update high severity vulnerability * 1.3.1 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ben Kelly <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues mentioned in https://github.com/StackEng/StackOverflow/pull/12658#discussion_r953802943, those issues being:
aria-hidden=trueattribute added via JSThere was mention of adding
aria-describedbyto elements with tooltips, but we already recommend that in Stacks documentation. Dynamically generated tooltips get anidand set the value of thearia-describedbyattribute on the reference element to thatid, so I think we should be all set there. I wasn't sure if settingaria-describedbyon tooltip generation was ok, but I saw this on MDN: