Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify highlight.js version #136

Closed
wants to merge 1 commit into from

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Jun 6, 2022

Describe your changes

This PR updates sets the version to ^11.5.1.

We were locked at 11.0.1 because it was specified in package-lock.json and we using * as the version in package.json.

Additional context

This should address some of this issues in #21.

Fixed with this PR

Not fixed with this PR

This PR updates sets the version to "^1.5.1."

We were locked at 11.0.1 because it was specified in package-lock.json and we using "*" as the version in package.json.
@dancormier dancormier requested a review from b-kelly June 6, 2022 16:22
@netlify
Copy link

netlify bot commented Jun 6, 2022

Deploy Preview for nifty-lalande-39c157 ready!

Name Link
🔨 Latest commit e15d6d3
🔍 Latest deploy log https://app.netlify.com/sites/nifty-lalande-39c157/deploys/629e29b71aa1b5000811e6ee
😎 Deploy Preview https://deploy-preview-136--nifty-lalande-39c157.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@double-beep
Copy link
Contributor

ref: highlightjs/highlight.js#3519

@b-kelly
Copy link
Collaborator

b-kelly commented Jun 13, 2022

I think this was set to * because hljs is a peerDependency, but I don't remember why exactly. I'll double check, bump the peerDependency version and address the failing unit tests.

@b-kelly
Copy link
Collaborator

b-kelly commented Jun 13, 2022

Fixed as part of aed987e, 785b52f and 6545fb2

@b-kelly b-kelly closed this Jun 13, 2022
@b-kelly b-kelly deleted the dcormier/explicit-highlightjs-version branch June 13, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants