Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2576: PhysicalConnection: Better shutdown handling #2629

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

NickCraver
Copy link
Collaborator

This adds a bit of null ref handling (few ifs). Fixes #2576.

Overall, this is biting people in the shutdown race, more likely under load, so let's eat the if checks here to prevent it. I decided to go with the specific approach here as to not affect inlining.

@NickCraver NickCraver marked this pull request as ready for review January 11, 2024 03:33
@NickCraver NickCraver requested a review from mgravell January 11, 2024 03:33
@NickCraver NickCraver merged commit b2694b3 into main Jan 11, 2024
7 checks passed
@NickCraver NickCraver deleted the craver/pipe-null-refs branch January 11, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG -> PhysicalConnection System.NullReferenceException:
3 participants