Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ivar version 1.4.3 #995

Merged
merged 1 commit into from
Aug 8, 2024
Merged

adding ivar version 1.4.3 #995

merged 1 commit into from
Aug 8, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of ivar!

It looks like this is mainly minor changes according to the release notes https://github.com/andersen-lab/ivar/releases/tag/v1.4.3

I, however, have made some major changes from the Dockerfile in 1.4.2:

  1. I added a builder stage where samtools, htslib, and ivar are installed
  2. There is no longer bedtools, bwa, or minimap2. I have tried using ivar's piping method, but it too slow for my purposes. If someone else uses this option, let me know and I can add them back in
  3. I added a CMD line

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara
Copy link
Collaborator

Thank you for putting all these together! I have no objection to removing bedtools, bwa, or minimap2.
I will merge this if nobody says against it.

@erinyoung
Copy link
Contributor Author

@kevinlibuit or @kapsakcj , do you use the ivar image? Do you think it'd be okay to remove bedtools, bwa, and minimap2 from it?

@kapsakcj
Copy link
Collaborator

We do use bwa & samtools within the ivar docker image, but don't use bedtools or minimap2

I'm fine either way if you want to remove all of those or keep some/all. We could make a custom image that includes everything we need if necessary.

@Kincekara Kincekara merged commit 24675a0 into master Aug 8, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for putting all this together!
Deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/10308039008

@erinyoung erinyoung deleted the erin-ivar branch September 25, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants