Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iqtree2 version 2.3.4 #977

Merged
merged 1 commit into from
May 20, 2024
Merged

iqtree2 version 2.3.4 #977

merged 1 commit into from
May 20, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of iqtree2!

There are some bug fixes and mixture options.

Full release log : https://github.com/iqtree/iqtree2/releases/tag/v.2.3.4

The prebuilt binary path is now different. I first tried "linux-arm", but that didn't run. "linux-intel" runs the tests as expected.

The full difference between dockerfiles version 2.3.1 and 2.3.4:

$ diff iqtree2/2.3*/Dockerfile
1c1
< ARG IQTREE2_VER="2.3.1"
---
> ARG IQTREE2_VER="2.3.4"
29,31c29,31
< RUN wget https://github.com/iqtree/iqtree2/releases/download/v${IQTREE2_VER}/iqtree-${IQTREE2_VER}-Linux.tar.gz && \
<     tar -xvf iqtree-${IQTREE2_VER}-Linux.tar.gz && \
<     rm -v iqtree-${IQTREE2_VER}-Linux.tar.gz && \
---
> RUN wget -q https://github.com/iqtree/iqtree2/releases/download/v.${IQTREE2_VER}/iqtree-${IQTREE2_VER}-Linux-intel.tar.gz && \
>     tar -xvf iqtree-${IQTREE2_VER}-Linux-intel.tar.gz && \
>     rm -v iqtree-${IQTREE2_VER}-Linux-intel.tar.gz && \
35c35
< ENV PATH="/iqtree-${IQTREE2_VER}-Linux/bin:${PATH}"\
---
> ENV PATH="/iqtree-${IQTREE2_VER}-Linux-intel/bin:${PATH}"\
52c52
< RUN iqtree2 -s /iqtree-${IQTREE2_VER}-Linux/example.phy --rate
---
> RUN iqtree2 -s /iqtree-${IQTREE2_VER}-Linux-intel/example.phy --rate

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara merged commit 024d7f8 into master May 20, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for the update!
Deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/9163795811.

@Kincekara
Copy link
Collaborator

@erinyoung failed on deployment. I think the binary link has changed.

@erinyoung erinyoung deleted the erin-iqtree2 branch May 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants