Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Freyja version 1.5.0 #923

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Adds Freyja version 1.5.0 #923

merged 3 commits into from
Mar 21, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of Freyja!

  • adds --depthcutoff features to account for available genome coverage, de-aliasing, and assignment of MRCAs
  • enables both true and relaxed MRCA assignment
  • incorporates collapsed MRCAs into summarization and plotting
  • some small speed improvements
  • option to set variants threshold above 0 for space constraints

I have put together a Dockerfile for version 1.5.0 and updated the corresponding GA workflow.

The only thing I changed in the Dockerfile was the version ARG:

$ diff freyja/1.4.9/Dockerfile freyja/1.5.0/Dockerfile 
5c5
< ARG FREYJA_SOFTWARE_VERSION="1.4.9"
---
> ARG FREYJA_SOFTWARE_VERSION="1.5.0"

The github action file has changed substantially in that

  1. Commented out steps have been deleted
  2. Pushing to repositories has been combined into one step
    2a. Pushing now includes overwriting the 'latest' tag

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara merged commit 92bff2f into master Mar 21, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for putting all these together!
You can check the image deployment from here: https://github.com/StaPH-B/docker-builds/actions/runs/8375236670.

@erinyoung erinyoung deleted the erin-freyja branch March 25, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants