Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ncbi datasets version 16.8.1 #919

Merged
merged 1 commit into from
Mar 18, 2024
Merged

adding ncbi datasets version 16.8.1 #919

merged 1 commit into from
Mar 18, 2024

Conversation

erinyoung
Copy link
Contributor

Yes, there were a lot of versions that I skipped (see https://github.com/ncbi/datasets/releases).

Most of the updates don't seem to impact the command line client, but a few do. Mostly small bug fixes.

I copied the files from 16.2.0 and made the following changes

  1. Updated the ARG for the software version
  2. Adjusted some Labels
  3. Adjusted the CMD line
$ diff ncbi-datasets/16.2.0/Dockerfile ncbi-datasets/16.8.1/
3c3
< ARG DATASETS_VER="16.2.0"
---
> ARG DATASETS_VER="16.8.1"
10c10,11
< LABEL website="https://www.ncbi.nlm.nih.gov/datasets/docs/v1/"
---
> LABEL website="https://github.com/ncbi/datasets"
> LABEL documentation="https://www.ncbi.nlm.nih.gov/datasets/docs/v1/"
35c36
< CMD [ "datasets" ]
---
> CMD [ "datasets", "--help" ]

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara merged commit 041e763 into master Mar 18, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for the update!
You can check the image deployment from here: https://github.com/StaPH-B/docker-builds/actions/runs/8330275407.

@erinyoung erinyoung deleted the erin-datasets branch March 25, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants