Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds Freyja 1.4.8 #826

Merged
merged 2 commits into from
Jan 2, 2024
Merged

adds Freyja 1.4.8 #826

merged 2 commits into from
Jan 2, 2024

Conversation

kapsakcj
Copy link
Collaborator

@kapsakcj kapsakcj commented Dec 29, 2023

PR adds a dockerfile for freyja v1.4.8.

Apologies to Erin, I know she contributed a PR to build these automatically with a github actions workflow 🙈 I'd prefer to get this docker image added manually before we attempt to use the GHActions workflow in PR #796

Changes from previous version's (1.4.7) dockerfile:

  • updated base image & LABEL to mambaorg/micromamba:1.5.6 from v1.4.9 of micromamba
  • dependencies installed via (bio)conda that were updated (via conda recipe change, I didn't update these myself)
    • biopython 1.81 ➡️ 1.82
    • matplotlib-base 3.7.2 ➡️ 3.8.2
    • pandas 2.0.3 ➡️ 2.1.4
    • samtools 1.17 ➡️ 1.19
    • scipy 1.11.1 ➡️ 1.11.4
    • usher 0.6.2 ➡️ 0.6.3
    • perhaps other versions changed, but these were the ones I noticed.

As long as the tests pass, I'm not too concerned about these dependency changes. Just wanted to note what has changed since the last freyja version.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@kapsakcj kapsakcj marked this pull request as ready for review December 29, 2023 19:11
@kapsakcj kapsakcj requested a review from kevinlibuit December 29, 2023 19:11
@kevinlibuit
Copy link
Contributor

Builds great on my end and no issues with tests run locally.

@kapsakcj kapsakcj merged commit e5137f1 into master Jan 2, 2024
2 checks passed
@kapsakcj kapsakcj deleted the freyja-1.4.8 branch January 2, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants