Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pasty 1.0.3 #794

Merged
merged 5 commits into from
Nov 14, 2023
Merged

add pasty 1.0.3 #794

merged 5 commits into from
Nov 14, 2023

Conversation

kapsakcj
Copy link
Collaborator

@kapsakcj kapsakcj commented Nov 14, 2023

This PR adds pasty v1.0.3

Dockerfile is identical to previous dockerfile except:

  • added test for bugfix included in v1.0.3 (TY Robert for adding another test!)
  • python version upgraded to 3.10.12 from 3.10.6

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@kapsakcj
Copy link
Collaborator Author

This will close issue #740

@kapsakcj kapsakcj marked this pull request as ready for review November 14, 2023 01:56
Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I added a hyperlink to the README, but I don't have any changes to recommend.

I'm going to

  1. merge this PR
  2. deploy to dockerhub and quay using the tag 1.0.3
  3. overwrite the latest tag

@erinyoung erinyoung merged commit a5d35f4 into master Nov 14, 2023
2 checks passed
@erinyoung
Copy link
Contributor

Thank you for your contribution!

You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/6867256311

@erinyoung
Copy link
Contributor

I'll let you delete your branch when you're ready

@kapsakcj kapsakcj deleted the cjk-pasty-1.0.3 branch November 14, 2023 17:29
@kapsakcj
Copy link
Collaborator Author

thanks for adding that link, I totally forgot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants