Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONTime version 0.2.3 #789

Merged
merged 2 commits into from
Nov 22, 2023
Merged

ONTime version 0.2.3 #789

merged 2 commits into from
Nov 22, 2023

Conversation

erinyoung
Copy link
Contributor

ONTime is great for evaluating ONT runs, specifically how long a ONT time should be run. It extracts reads based on the time to the read was generated.

This tool was not yet in the docker-builds repo, so I have added ONTime to the LICENSES.md and README.md as well as creating the files for pushing.

I have also included a fastq file from a nanopore sequencing run we did in-house because ONTime needs the time stamps that are often scrubbed in public repositories.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara
Copy link
Collaborator

This looks great! Merging...

@Kincekara Kincekara merged commit 7138685 into master Nov 22, 2023
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for your PR!
You can check the deploy from here: https://github.com/StaPH-B/docker-builds/actions/runs/6960436930

@erinyoung erinyoung deleted the erin-ontime branch November 28, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants