Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blast+ to version 2.14.1 #770

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Update blast+ to version 2.14.1 #770

merged 4 commits into from
Oct 25, 2023

Conversation

Haikelnb
Copy link
Contributor

@Haikelnb Haikelnb commented Oct 24, 2023

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor

This looks great! I only have one edit that I request of you:

Add blast version 2.14.1 to the README.md file at https://github.com/Haikelnb/docker-builds/edit/master/README.md (blast is line 120), and, optionally, you can add your handle to the bottom of that readme where contributors are listed.

@erinyoung
Copy link
Contributor

This PR will close #724

Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you!

I am going to

  • merge this PR
  • push this to dockerhub and quay with the tag 2.14.1
  • overwrite the latest tag

@erinyoung erinyoung merged commit ec8becd into StaPH-B:master Oct 25, 2023
2 checks passed
@erinyoung
Copy link
Contributor

You can see the status of the deployment here : https://github.com/StaPH-B/docker-builds/actions/runs/6644754362

The deployed images will be available on both dockerhub (https://hub.docker.com/r/staphb/blast) and quay (https://quay.io/repository/staphb/blast).

Thank you for your contribution! (And for finishing the homework for the docker workshop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants