Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding longshot version 0.4.5 #721

Merged
merged 2 commits into from
Nov 2, 2023
Merged

adding longshot version 0.4.5 #721

merged 2 commits into from
Nov 2, 2023

Conversation

erinyoung
Copy link
Contributor

To make a "long" story short, this is dependency for another image that I'd like to create.

Longshot is a variant caller that specializes in noisy reads - like those of pacbio or nanopore.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung erinyoung requested a review from Kincekara October 24, 2023 20:08
@erinyoung
Copy link
Contributor Author

@Kincekara , do you have time to review this?

@kapsakcj
Copy link
Collaborator

kapsakcj commented Nov 1, 2023

I can review this over the weekend if Kutluhan is not available

@Kincekara
Copy link
Collaborator

@erinyoung Sorry, I didn't see your message. I am checking it now.

Modified read me to comply with new templates.

Main tool : [longshot](https://github.com/pjedge/longshot)

Code repository: https://github.com/pjedge/longshot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified Read Me to comply with new templates and trigger checks.

@Kincekara Kincekara merged commit 8c6937d into master Nov 2, 2023
2 checks passed
@Kincekara
Copy link
Collaborator

I merged and deployed your PR.
You can follow the progress from https://github.com/StaPH-B/docker-builds/actions/runs/6732773244.
Thank you for your contribution!

@kapsakcj
Copy link
Collaborator

kapsakcj commented Nov 2, 2023

TY @Kincekara !

@erinyoung
Copy link
Contributor Author

Thank you!

@erinyoung erinyoung deleted the erin-update-artic-medaka branch November 7, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants