-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add srst2 0.2.0 with custom Vibrio cholerae database #618
Conversation
…s; added python-setuptools to apt-get install cmd; corrected comments; made samtools untar less verbose; made cp command more verbose. Builds successfully
…ecessary samtools tarball
…n of FASTA file; updated example command with new path to FASTA file
… tool-specific README.md
I suggest that we set this PR as draft until we test the container on more V. cholerae samples. Just want to put this container through more extensive testing before merging the PR here. I've pushed the docker image to my personal quay repo that we can use for testing in Terra: https://quay.io/repository/kapsakcj/srst2?tab=tags docker image name |
Clarified ompW information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great as far as README.md changes go and the dockerfile itself.
GHActions test worked as expected, including the V. cholerae test sample as having hits to the expected ctxA, ompW, tcpA_ElTor, toxR, and wbeN O1 markers.
Further tests done in Terra (not shown here), also show concordance between expected phenotypes (PCR positivity) & in silico detection via srst2 approach
I will now deploy this to dockerhub & quay the the docker image name and tag: staphb/srst2:0.2.0-vcholerae
. I will also overwrite the staphb/srst2:latest
tag on dockerhub & quay.
Thank you!
you can view the deployment workflow progress here: https://github.com/StaPH-B/docker-builds/actions/runs/4621877426 I expect the docker images will be available on dockerhub & quay in the next 15 min or so |
Motivation
This PR adds a custom vibrio database to the srst2 0.2.0 container with sequences used for in silicon typing. It contains minimal alterations and the description of the database has been added to the README file.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)