-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding krona 2.8.1 with krakentools #1164
base: master
Are you sure you want to change the base?
Conversation
This isn't an issue for @sage-wright , but it is strange that GA didn't pick up the new Dockerfile.
I'm unsure why it didn't work, so I may have to mess with this PR to see if I can trigger the GA. |
Closes #632 |
The GHActions is not working because the "get-changed-files" step in the workflow has a filter to look for changed files matching:
and the file that is added in this PR is:
So I think there needs to be an additional subdir with the version number of krona, e.g. |
Ah. Yes. That's kind of obvious... |
Oh oops haha. I knew I was forgetting something obvious. I'll fix that and make the requested changes as well 🙂 |
@erinyoung, it looks like the shebang for the KrakenTools scripts is incompatible w/ how I've installed Python. It's looking for |
Krona is a pretty cool tool for visualizing metagenomic data. However, it's got a weird quirk where if you want to look at viral metagenomic data, you'll have to run it through KrakenTools before in order to make sure that the viral sequences don't show up as "other root".
This image has both the latest version of krona and the commit of krakentools used in the already existing docker image within staphb.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15
)docker-builds/build-files/spades/3.12.0/Dockerfile
)[ ] (optional) All test files are located in same directory as the Dockerfile (i.e.build-files/shigatyper/2.0.1/test.sh
)docker-builds/build-files/spades/3.12.0/README.md
)