Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding core-snp-filter version 0.2.0 #1125

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

erinyoung
Copy link
Contributor

Core-SNP-filter is like snippy, but faster and with more options.

This image is larger than that of biocontainers, but since only wget and ca-certificates are installed via wget, I think I would need to use a different base if this were to be smaller.

$ docker image ls
REPOSITORY                              TAG                 IMAGE ID       CREATED          SIZE
coresnpfilter                           app                 37663fc1a92f   8 minutes ago    82.9MB
quay.io/biocontainers/core-snp-filter   0.2.0--h3ab6199_2   5b3d2cbac80a   5 hours ago      29.2MB

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara
Copy link
Collaborator

@erinyoung, if you want to save more space, you can use the wget --no-check-certificate option to skip the installation of ca-certificates. However, because of the base image, it still won't be as small as the biocontainer image as you thought.
This looks good as it is. I will merge and deploy...

@Kincekara Kincekara merged commit 18e30fa into StaPH-B:master Dec 17, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for your contribution!
The deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/12381718923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants