-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds updated Dorado 0.8.3 #1107
Conversation
@fraser-combe , normally we just add new functionality in the latest release. Were you planning on using version 0.8.0 once 0.8.3 was deployed? |
My bad, I didnt mean to edit the 0.8.0 files, I have corrected and repushed |
Image built locally successfully
|
Here's the dockerfile diff:
Thanks for sharing the output of the test 👍 I expect the github actions wf to fail due to hard drive size just like the last time. I've built the image locally and have pushed it up to dockerhub and quay.io. Here are the commands I ran: # build/tag images locally
docker_build --target app -t staphb/dorado:0.8.3 dorado/0.8.3
docker_build --target app -t staphb/dorado:latest dorado/0.8.3
docker_build --target app -t quay.io/staphb/dorado:latest dorado/0.8.3
docker_build --target app -t quay.io/staphb/dorado:0.8.3 dorado/0.8.3
# push images to quay and dockerhub
docker push quay.io/staphb/dorado:0.8.3
docker push quay.io/staphb/dorado:latest
docker push staphb/dorado:latest
docker push staphb/dorado:0.8.3 |
Update Dorado to version 0.8.3 with Pigz support
The Dockerfile has minor changes from version 0.8.0:
0.8.3
.pigz
dependency to enable faster zipping of files from Dorado outputs.The Docker image was successfully built and verified using the following commands:
docker run --rm dorado:0.8.3 dorado basecaller --help
docker run --rm dorado:0.8.3 dorado --version
Please replace all '[ ]' with '[X]' to demonstrate completion.
-->
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)