Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding krakentools version d4a2fbe #1079

Merged
merged 12 commits into from
Oct 23, 2024
Merged

adding krakentools version d4a2fbe #1079

merged 12 commits into from
Oct 23, 2024

Conversation

sage-wright
Copy link
Contributor

This PR adds the KrakenTools set of scripts to a docker image. The last release was ages ago, so I've used the latest commit hash instead.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • [ ] (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • [ ] If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@sage-wright sage-wright changed the title KrakenTools:d4a2fbe adding krakentools:d4a2fbe Oct 10, 2024
@sage-wright sage-wright changed the title adding krakentools:d4a2fbe adding krakentools version d4a2fbe Oct 10, 2024
@kapsakcj kapsakcj self-requested a review October 10, 2024 15:33
Copy link
Collaborator

@kapsakcj kapsakcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small comments and changes made to the readme for kraken tools. Once we address the pinning of the python packages, I'm good to merge and deploy the docker image.

Nice work!

@kapsakcj
Copy link
Collaborator

Will deploy the docker image to dockerhub and quay in a moment, and will use the shortened commit hash as the tag.

So on dockerhub and quay we will see the docker image name & tag staphb/krakentools:latest and staphb/krakentools:d4a2fbe

@kapsakcj kapsakcj merged commit 1610fdf into StaPH-B:master Oct 23, 2024
2 checks passed
@kapsakcj
Copy link
Collaborator

kapsakcj commented Oct 23, 2024

deploy workflow here if you'd like to follow along https://github.com/StaPH-B/docker-builds/actions/runs/11484050854

it should be available in the next 5-10 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants