-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds bbtools 39.10 #1076
adds bbtools 39.10 #1076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no changes to recommend. Thank you for putting this together!
I'm going to deploy this to dockerhub and quay for the 'staphb/bbtools' image with the tag '39.10' and I'll overwrite the 'latest' tag.
Actually, do we think this message matters?
|
This test passed:
|
I couldn't reproduce the error. I also realized there are 218 scripts and we don't see most of the output. That loop in the test is not very useful so I removed it completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for looking into it!
I'm going to
- merge this PR
- push to staphb's repository in dockerhub and quay
- use the tags '39.10' and 'latest'
Thank you for putting this together! You can check the status of the deployment here : https://github.com/StaPH-B/docker-builds/actions/runs/11184915234 |
Looks like the deployment didn't work, so I've re-launched it : https://github.com/StaPH-B/docker-builds/actions/runs/11184915234 |
fixed #1085 |
I have updated samtools and htslib along with the BBTools. I removed the loop from CMD since it had created a novel from help. Now, it shows a table of tools.
I also renewed the legacy readme.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)