Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding datasets version 16.30.0 #1063

Merged
merged 1 commit into from
Sep 30, 2024
Merged

adding datasets version 16.30.0 #1063

merged 1 commit into from
Sep 30, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of datasets!

Well... lot's of them. Mostly it looks like minor updates recently, but I don't want to get too far behind.

I just copied the prior dockerfile and updated the software version arg.

The full diff.

$ diff ncbi-datasets/16.22.1/Dockerfile ncbi-datasets/16.30.0/Dockerfile 
3c3
< ARG DATASETS_VER="16.22.1"
---
> ARG DATASETS_VER="16.30.0"

Pull Request (PR) checklist:

  • [x]Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara merged commit d27fdc1 into master Sep 30, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for the update! It is hard to catch datasets versions.
Here is the deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/11111481495

@erinyoung erinyoung deleted the erin-datasets branch October 7, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants