You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a new version of vigor4 and more databases!
Right now this is a work in progress as we get tests together, but it should be ready for review soon.
Edit: This is now ready to review!
I made several changes from the prior Dockerfile. I added an 'app' and 'test' stage. I thought about adding a 'builder' stage so that maven wasn't included in the final image, but then I determined that wasn't worth my time at the moment. I can implement this stage if the reviewer thinks otherwise.
I also added in a CMD layer and created a README.
Pull Request (PR) checklist:
Include a description of what is in this pull request in this message.
The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
(optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
If this README is longer than 30 lines, there is an explanation as to why more detail was needed
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a new version of vigor4 and more databases!
Right now this is a work in progress as we get tests together, but it should be ready for review soon.Edit: This is now ready to review!
I made several changes from the prior Dockerfile. I added an 'app' and 'test' stage. I thought about adding a 'builder' stage so that maven wasn't included in the final image, but then I determined that wasn't worth my time at the moment. I can implement this stage if the reviewer thinks otherwise.
I also added in a CMD layer and created a README.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15)spades/3.12.0/Dockerfile)shigatyper/2.0.1/test.sh)spades/3.12.0/README.md)