Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds pangolin with pdata v1.29 #1027

Merged
merged 5 commits into from
Jul 30, 2024
Merged

adds pangolin with pdata v1.29 #1027

merged 5 commits into from
Jul 30, 2024

Conversation

kapsakcj
Copy link
Collaborator

@kapsakcj kapsakcj commented Jul 30, 2024

Will mark ready for review shortly, setting as draft for now. Ready for review, I added a test for KP.3.3.2 & upgraded to pangolin-data v1.29. All else is the same as the last dockerfile

Pretty simple upgrade, only one code change in the Dockerfile so far. May add a test for a new lineage if I can find a test genome on NCBI

$ diff pangolin/4.3.1-pdata-1.28.1/Dockerfile pangolin/4.3.1-pdata-1.29/Dockerfile 
12c12
< ARG PANGOLIN_DATA_VER="v1.28.1"
---
> ARG PANGOLIN_DATA_VER="v1.29"
199a200,208
> 
> # new lineage KP.3.3.2 that was introduced in pango-designation v1.29: https://github.com/cov-lineages/pango-designation/commit/7125e606818312b78f0756d7fcab6dba92dd0a9e
> # genome on NCBI: https://www.ncbi.nlm.nih.gov/nuccore/PQ073669
> RUN datasets download virus genome accession PQ073669.1 --filename PQ073669.1.zip && \
> unzip PQ073669.1.zip && rm PQ073669.1.zip && \
> mv -v ncbi_dataset/data/genomic.fna PQ073669.1.genomic.fna && \
> rm -vr ncbi_dataset/ README.md && \
> pangolin PQ073669.1.genomic.fna -o PQ073669.1-usher && \
> column -t -s, PQ073669.1-usher/lineage_report.csv
\ No newline at end of file

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@kapsakcj kapsakcj marked this pull request as ready for review July 30, 2024 20:11
@kapsakcj
Copy link
Collaborator Author

I propose to use the same syntax for docker image tag: staphb/pangolin:4.3.1-pdata-1.29 and overwrite the :latest tag

@Kincekara
Copy link
Collaborator

It looks like KP.3.3.2 can be detected successfully. Previous tests are cached, but I assume they are good. I will merge and deploy this...

@Kincekara Kincekara merged commit af47652 into master Jul 30, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for the update!
Deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/10169350031

@kapsakcj kapsakcj deleted the cjk-pdata-1.29 branch July 30, 2024 20:35
@kapsakcj
Copy link
Collaborator Author

thank you for the speedy review & deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants