Fix issues with play dependency #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Srikrishna31
force-pushed
the
play_dependency
branch
from
0242751
to
c523723
Compare
added 7 commits
September 26, 2020 08:21
Move the rules_scala, google_protobuff dependencies into their own .bzl files, and load them from WORKSPACE file, to keep it clean. Any new dependency like this should be handled similarly.
1. Add dependency on play-routes from here: https://github.com/lucidsoftware/rules_play_routes 2. Add dependency on rules_jvm_external from here: https://github.com/bazelbuild/rules_jvm_external 3. Add dependency on play-twirl from here: https://github.com/lucidsoftware/rules_twirl 4. play-twirl is not yet working. Need to fix it in future.
Empty call to maven_install, to make sure all is well in atleast calling it. Create the main app target, which combines model and controllers.
In progress for converting other targets.
Srikrishna31
force-pushed
the
play_dependency
branch
from
c043732
to
fea9b07
Compare
Srikrishna31
force-pushed
the
play_dependency
branch
2 times, most recently
from
d9d5245
to
3648135
Compare
Dependencies are listed here: akka/akka-grpc#386 (comment)
Srikrishna31
force-pushed
the
play_dependency
branch
from
3648135
to
41f2455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to convert to a proper play application.
This repo: https://github.com/akashdayal/play-scala-rest-api-example-2.5.x-bazel/ can be used as an example to follow.