Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use PlotOutline instead of Plot if available in Views and Featured section. #11

Open
henkdevries opened this issue Apr 7, 2013 · 2 comments

Comments

@henkdevries
Copy link

Most movie plots are too long to fit in the Featured section or in the space available in most views. The plotoutline on the other hand almost always fits. (And usually contains less spoilers)

Changing the variable ExtendedList_Detail seems to fix this for Grid, Extended and Thumb views.

For the Featured box I've defined a variable for each RandomMovie, but probably you can think of a more efficient solution:

<variable name="RandomMovie_1_Plot">
    <value condition="!IsEmpty(Window(Home).Property(RandomMovie.1.PlotOutline))">$INFO[Window(Home).Property(RandomMovie.1.PlotOutline)]</value>
    <value>$INFO[Window(Home).Property(RandomMovie.1.Plot)]</value>
</variable>
@Sranshaft
Copy link
Owner

The problem with switching to PlotOutline is that it is not always filled by the scraper. The default movie scraper (TheMovieDB) doesn't include PlotOutline, which is something I wish it did as I would prefer to have it the way you described.

In the meantime I will update the skin to include the PlotOutline with a fallback to Plot in case it's empty as I imagined you've done already.

Sranshaft pushed a commit that referenced this issue Apr 8, 2013

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Partial fix for issue #11
@henkdevries
Copy link
Author

I see the problem with the TMDB scraper, but sadly even the Universal scraper does not find a PlotOutline for every movie so a fallback to plot is indeed necessary.

My solution for the Featured section of the Movie Hub does also include a fallback:

I added six variables in Variables.xml (RandomMovie_2_Plot until RandomMovie_7_Plot) as described in my first comment

In ViewList.xml I've changed the label2 in all 6 randommovies items to:

                    <label2>$VAR[RandomMovie_2_Plot]</label2>

until

                    <label2>$VAR[RandomMovie_7_Plot]</label2>

The only thing bothering me about this solution is the apparent redundancy in the variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants