Allow `--releasify` to specify the required .NET framework version #940

NeilSorensen · 2017-01-30T17:51:07Z

A proposed solution for #341

Setting IDS_FXVERSION now lets you specify a required .NET Framework version between 4.5 and 4.6.2

GorelH · 2017-02-25T12:24:47Z

@NeilSorensen thanks you for your effort. is this testable ?

NeilSorensen · 2017-03-01T20:51:34Z

Unfortunately, I couldn't find any tests on any of the code that I changed. The most important change is also probably the least testable, because it depends on resources.

If I missed some tests, I'd be happy to modify them if you can point them out to me

anaisbetts · 2017-03-13T22:08:53Z

src/Setup/FxHelper.cpp


 	WCHAR szTempPath[_MAX_PATH];
 	DWORD dwTempPathResult = GetTempPath(_MAX_PATH, szTempPath);

 	if (dwTempPathResult == 0) {
 		hr = AtlHresultFromLastError();
 		goto out;
-	} else if (dwTempPathResult > _MAX_PATH) {
+	}
+	else if (dwTempPathResult > _MAX_PATH) {


Move this to the previous line

anaisbetts · 2017-03-13T22:09:58Z

src/Update/Program.cs

@@ -434,8 +436,14 @@ public void Releasify(string package, string targetDir = null, string packagesDi

            var writeZipToSetup = findExecutable("WriteZipToSetup.exe");

-            try {
-                var result = Utility.InvokeProcessAsync(writeZipToSetup, String.Format("\"{0}\" \"{1}\"", targetSetupExe, zipPath), CancellationToken.None).Result;
+            try


Please match the existing code style with braces

anaisbetts · 2017-03-13T22:10:46Z

src/Update/Program.cs

+            try
+            {
+                var arguments = String.Format("\"{0}\" \"{1}\"", targetSetupExe, zipPath);
+                if (!String.IsNullOrEmpty(frameworkVersion))


Can we just default this to .NET 4.5?

anaisbetts · 2017-03-13T22:11:04Z

src/WriteZipToSetup/WriteZipToSetup.cpp

+	if (argc == 5 && wcscmp(argv[3], L"--set-required-framework") == 0) {
+		setFramework = true;
+	}
+	else if (argc != 3) {


I'm a little confused by what you'd like here. If --set-required-framework is unspecified, it will not overwrite the default value of net45, which is set in setup resources. Would you prefer WriteZipToSetup to always overwrite that value? Or are you suggesting making --set-required-framework a required flag for WriteZipToSetup?

Nevermind, that's a style change...

anaisbetts · 2017-03-13T22:11:26Z

This seems reasonable, I've marked some style changes but other than that, thanks for the PR

Cheesebaron · 2017-04-07T08:49:27Z

@NeilSorensen what can we do to get those style changes fixed so this PR can be merged?

NeilSorensen · 2017-04-07T16:06:33Z

Sorry, life got in the way for a while. I'll get it updated today

koliva8245 · 2017-04-12T15:32:47Z

@NeilSorensen Could you update this for .NET 4.7?

NeilSorensen · 2017-04-13T17:12:43Z

@koliva8245 as I understand it, .NET 4.7 is not yet released for anything other than Windows 10 with the creator's update. Once it hits wide release, it should be fairly simple to add it as well

anaisbetts · 2017-04-15T07:14:04Z

I'll try to get this out soon, if I forget please start harassing me on Twitter dot com until I do it :)

chadgrant · 2017-04-27T22:33:29Z

:(

anaisbetts · 2017-05-01T19:48:55Z

Thanks so much @NeilSorensen!

vegardlarsen · 2017-05-12T10:38:21Z

Anyone working on getting .NET 4.7 support for this?

danielkornev · 2017-05-29T20:34:08Z

460798 is a Release number for .NET 4.7 on Windows 10 CU RTM (with latest cumulative updates):

Version: 4.7.02046

dealproc · 2018-04-22T08:48:47Z

Can someone add docs for this? I recalled this was available, but had to come back to this bug to find out the cmd line switch.

cbenard · 2018-05-18T17:35:27Z

@dealproc Agreed. I'm not 100% either. Based on looking at the code, it looks like you pass --set-required-framework net471 to releasify. I don't see any docs in google mentioning --set-required-framework though.

dealproc · 2018-07-09T14:25:08Z

Options:
  -h, -?, --help             Display Help and exit
  -r, --releaseDir=VALUE     Path to a release directory to use with releasify
  -p, --packagesDir=VALUE    Path to the NuGet Packages directory for C# apps
      --bootstrapperExe=VALUE
                             Path to the Setup.exe to use as a template
  -g, --loadingGif=VALUE     Path to an animated GIF to be displayed during
                               installation
  -i, --icon=VALUE           Path to an ICO file that will be used for icon
                               shortcuts
      --setupIcon=VALUE      Path to an ICO file that will be used for the
                               Setup executable's icon
  -n, --signWithParams=VALUE Sign the installer via SignTool.exe with the
                               parameters given
  -s, --silent               Silent install
  -l, --shortcut-locations=VALUE
                             Comma-separated string of shortcut locations, e.g.
                               'Desktop,StartMenu'
      --no-msi               Don't generate an MSI package
      --no-delta             Don't generate delta packages to save time
      --framework-version=VALUE
                             Set the required .NET framework version, e.g.
                               net461

Thanks for the tip. I should have checked the console help (above) which has it.

NeilSorensen added 4 commits January 27, 2017 17:41

Make the .NET Framework required specifiable

609f5a6

Setting IDS_FXVERSION now lets you specify a required .NET Framework version between 4.5 and 4.6.2

It turns out that string tables are a pain to write to

1dc2a69

Have WriteZipToSetup also optionally set the required framework flag

967ca61

Add a --framework-version option to squirrel.exe

ce5dea6

anaisbetts reviewed Mar 13, 2017

View reviewed changes

Style changes to match existing code better

2b8d804

anaisbetts merged commit f92dc4e into Squirrel:master May 1, 2017

CallumWatkins mentioned this pull request May 27, 2017

Multi-Framework Support #188

Closed

lukeskinner mentioned this pull request Jun 2, 2017

.NET 4.7 Compattableity #1040

Closed

plinehan mentioned this pull request Nov 20, 2017

Specify required .NET version #341

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `--releasify` to specify the required .NET framework version #940

Allow `--releasify` to specify the required .NET framework version #940

NeilSorensen commented Jan 30, 2017

GorelH commented Feb 25, 2017

NeilSorensen commented Mar 1, 2017 •

edited

Loading

anaisbetts Mar 13, 2017

anaisbetts Mar 13, 2017

anaisbetts Mar 13, 2017

anaisbetts Mar 13, 2017

NeilSorensen Apr 7, 2017

NeilSorensen Apr 7, 2017

anaisbetts commented Mar 13, 2017

Cheesebaron commented Apr 7, 2017

NeilSorensen commented Apr 7, 2017

koliva8245 commented Apr 12, 2017

NeilSorensen commented Apr 13, 2017

anaisbetts commented Apr 15, 2017

chadgrant commented Apr 27, 2017

anaisbetts commented May 1, 2017

vegardlarsen commented May 12, 2017

danielkornev commented May 29, 2017

dealproc commented Apr 22, 2018

cbenard commented May 18, 2018

dealproc commented Jul 9, 2018

Allow --releasify to specify the required .NET framework version #940

Allow --releasify to specify the required .NET framework version #940

Conversation

NeilSorensen commented Jan 30, 2017

GorelH commented Feb 25, 2017

NeilSorensen commented Mar 1, 2017 • edited Loading

anaisbetts Mar 13, 2017

Choose a reason for hiding this comment

anaisbetts Mar 13, 2017

Choose a reason for hiding this comment

anaisbetts Mar 13, 2017

Choose a reason for hiding this comment

anaisbetts Mar 13, 2017

Choose a reason for hiding this comment

NeilSorensen Apr 7, 2017

Choose a reason for hiding this comment

NeilSorensen Apr 7, 2017

Choose a reason for hiding this comment

anaisbetts commented Mar 13, 2017

Cheesebaron commented Apr 7, 2017

NeilSorensen commented Apr 7, 2017

koliva8245 commented Apr 12, 2017

NeilSorensen commented Apr 13, 2017

anaisbetts commented Apr 15, 2017

chadgrant commented Apr 27, 2017

anaisbetts commented May 1, 2017

vegardlarsen commented May 12, 2017

danielkornev commented May 29, 2017

dealproc commented Apr 22, 2018

cbenard commented May 18, 2018

dealproc commented Jul 9, 2018

Allow `--releasify` to specify the required .NET framework version #940

Allow `--releasify` to specify the required .NET framework version #940

NeilSorensen commented Mar 1, 2017 •

edited

Loading