Fix Content Types created by Mono

[kevinmartin]

Attempts to remove default content types in [Content_Types].xml with empty Extensions.

This happens when adding a file via your NuSpec file with no extension, such as LICENSE.

Fixes #520

/cc @fasterthanlime

[fasterthanlime]

This is basically a workaround for a nupkg bug right? It should probably be fixed upstream instead.

[kevinmartin]

I'm not really familiar with nupkg/nuget, unfortunately.

Plus, this is backwards compatible with previous versions of nupkg/nuget.

[anaisbetts]

Yeah, while I agree with @fasterthanlime in principle, in reality this is probably going to be Very Arduous

[kevinmartin]

I also agree. The ideal scenario would be to fix upstream. But...

• The NuGet.exe in Squirrel.Windows is 2 years old.
• And the nuget.exe in atom/grunt-electron-installer is 1 year old.
• And the nuget.exe in all of the popular forks of atom/grunt-electron-installer, such as electronjs/windows-installer, Aluxian/electron-windows-installer, and mongodb-js/electron-installer-squirrel-windows all use the same 1 year old nuget.exe.

[fasterthanlime]

I was going to mention that the workaround would be a good idea if it was one of the last holdouts for getting a complete Squirrel.Windows toolchain working on Linux.. but the Microsoft patching package is the real problem there, not the LICENSE file.

However, if nobody bothers updating their NuGet.exe, then that workaround might be very welcome/useful. 👍

[kevinmartin]

@paulcbetts is this good to be merged then or are there any changes you would like me to do?

[anaisbetts]

@kevinmartin It's probably fine, I'll look at it soon

[anaisbetts]

Thanks!