Kill processes belonging to us on install and uninstall #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var pbi = new PROCESS_BASIC_INFORMATION(); | ||
|
|
||
| //Get a handle to our own process | ||
| IntPtr hProc = OpenProcess((ProcessAccess)0x001F0FFF, false, Process.GetCurrentProcess().Id); |
There was a problem hiding this comment.
Can you use the enum here instead of the literal?
There was a problem hiding this comment.
This is just moved code from long ago, but yeah, probably - this is calling undocumented methods so it might not be possible
|
Could maybe beef up the tests around this scenario, although there's no way to mock them. |
anaisbetts
added a commit
that referenced
this pull request
Feb 5, 2016
Kill processes belonging to us on install and uninstall
|
@paulcbetts so this #358 is not necesary anymore? |
|
@ricardopolo Nope! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain types of apps, it's super easy to run the installer while the app is still running. This of course fails, but users think it is just because the installer has a bug. Enact Process Violence to stop this from occurring