update support, 64bit support, better naming #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaisbetts
reviewed
Feb 28, 2019
src/Update/Program.cs
Outdated
| @@ -134,6 +135,7 @@ int executeCommandLine(string[] args) | |||
| { "no-msi", "Don't generate an MSI package", v => noMsi = true}, | |||
| { "no-delta", "Don't generate delta packages to save time", v => noDelta = true}, | |||
| { "framework-version=", "Set the required .NET framework version, e.g. net461", v => frameworkVersion = v }, | |||
| { "arch=", "Defines the architecure of the MSI package, e.g x64", v => packageAs64Bit = v == "x64"}, | |||
There was a problem hiding this comment.
This is kind of a fib, since I can't specify like, arm or ia64 here. Can we rename this to msi-win64=true? I'd also like to make the doc string something like:
Mark the MSI as 64-bit, which is necessary for some Enterprise deployment technologies
There was a problem hiding this comment.
My thought behind using the more generic option here was to have the freedom for possible future adjustments related to architecture without introducing yet another option. But if you feel msi-win64 is the better choice then it works for me to.
anaisbetts
reviewed
Feb 28, 2019
bitdisaster
force-pushed
the
MSI_improvements
branch
from
a8abc85 to
5caf51d
Compare
bitdisaster
force-pushed
the
MSI_improvements
branch
from
dd4c65a to
b7fb7ff
Compare
|
all addressed |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings several MSI improvements that were repeatedly requested by customers (IT administrators)
Update Support
The WIX template already accommodated a
<UpgradeCode/>tag that is necessary uninstalling older versions of the MSI. However, to actually trigger an uninstall when installing a new one, it was missing the<MajorUpgrade/>tag. No more. Old version will be removed now.64bit Support
When offering your App as 64-bit, administrators also expect the installer package to behave 64-bit. Meaning that the installer is puts things under
Program FilesnotProgram Files (x86)and registry keys are written underHKLM\SOFTWARE\...and notHKLM\SOFTWARE\WOW6432Node\...A new optional parameter-arch=VALUEallows to define the architecture for the packaging process. While only the valuex64will currently have an effect, it leaves the door open for future architecture differentiations.Better Naming
Many customer struggle with the concept what the MSI in Squirrel is and what machine-wide installer in this context means. Naming the MSI
MyApp Machine-Wide installerimplies that actually MyApp gets installed machine-wide when in reality only an installer that installs MyApp gets installed. So this PR attempts to make it more clear what the MSI is and what it installs. The best way to describe it is an installer for a tool that helps deployMyAppon per-user bases. Therefor the MSI will be listed asMyApp Per-User Deployment. Also the new folder naming should make it clear what gets installed.C:\Program Files\MyApp Deployment\MyAppDeploymentTool.exe