Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop downloading remote updates that are lower than the current version #1001

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Stop downloading remote updates that are lower than the current version #1001

merged 1 commit into from
Jun 19, 2017

Conversation

ilyalopatkin
Copy link

If the current version is not present on the update server then currently it will download the latest available (which is older), unpack it, and then after an app restart clean up by deleting it. This change makes sure old updates are not considered thus simply skipping the update process. This is needed for running the newly built versions (for testing purposes) which haven't been uploaded to the update server yet.

@anaisbetts anaisbetts merged commit b493d57 into Squirrel:master Jun 19, 2017
@anaisbetts
Copy link
Contributor

Thanks @ilyalopatkin!

@Mr-Wallet
Copy link

Is it now impossible to "downgrade" clients as a result of this change? i.e. if there is a catastrophic release that requires an immediate revert, is the only fix to re-build the prior version with a higher semver?

@anaisbetts
Copy link
Contributor

Correct

@Mr-Wallet
Copy link

Thank you for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants