Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignTool password masking fails with special characters #974

Closed
markgould opened this issue Mar 17, 2017 · 1 comment
Closed

SignTool password masking fails with special characters #974

markgould opened this issue Mar 17, 2017 · 1 comment
Labels
help wanted Issues and features that are open to external contribution

Comments

@markgould
Copy link

The password masking implemented in #861 fails if the password contains a special character.

For example a password of 1@234567 will show in the logs as ********@234567

@shiftkey
Copy link
Contributor

shiftkey commented May 5, 2019

@markgould I'd take a PR to improve this regex to capture anything that looks like text

var optsWithPasswordHidden = new Regex(@"/p\s+\w+").Replace(signingOpts, "/p ********");
var msg = String.Format("Failed to sign, command invoked was: '{0} sign {1} {2}'",
exe, optsWithPasswordHidden, exePath);

@shiftkey shiftkey added the help wanted Issues and features that are open to external contribution label May 5, 2019
anaisbetts added a commit that referenced this issue Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues and features that are open to external contribution
Projects
None yet
Development

No branches or pull requests

2 participants