Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Try to unquarantine the host app before checking for updates. #183

Closed
wants to merge 2 commits into from
Closed

[WIP] Try to unquarantine the host app before checking for updates. #183

wants to merge 2 commits into from

Conversation

joshaber
Copy link
Contributor

Fixes #182

@joshaber joshaber mentioned this pull request Sep 29, 2016
Closed
keithduncan
keithduncan approved these changes Oct 3, 2016
View reviewed changes
Copy link
Member

@keithduncan keithduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense based on the discussions linked from the issue. I'm surprised an app is allowed to self remove the quarantine but though, that would appear to defeat the protection aspect too 🤔

@joshaber
Copy link
Contributor Author

joshaber commented Oct 3, 2016

I'm surprised an app is allowed to self remove the quarantine but though, that would appear to defeat the protection aspect too

Yeah I'm curious to see if this actually works once I figure out how to test it.

@keithduncan
Copy link
Member

I've confirmed that removing com.apple.quarantine from the app fixes this

Ah I misinterpreted this as you having tested it. Right on, I suspect this will in fact not work then 😉

@joshaber
Copy link
Contributor Author

joshaber commented Oct 6, 2016 •
edited
Loading

Yeah, I mean, thinking about this, surely NSRunningApplication.currentApplication.bundleURL would be the randomized path, in which case removexattr on it is just a joke.

@keithduncan
Copy link
Member

Yeah, I mean, thinking about this, surely NSRunningApplication.currentApplication.bundleURL would be the randomized path, in which case removexattr on it is just a joke.

True that, does path randomisation kick in even when you’re sandboxed?

/cc @paulcbetts for details on the magic sandbox update entitlement

@joshaber joshaber mentioned this pull request Oct 10, 2016
Closed
@joshaber
Copy link
Contributor Author

Superseded by #186

@joshaber joshaber closed this Oct 14, 2016
@joshaber joshaber deleted the clear-the-quarantine-bit-on-the-host-app branch October 14, 2016 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithduncan keithduncan keithduncan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshaber @keithduncan