Add support for Google OAuth authentication (via simple_google_auth gem) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mexisme
changed the title
mexisme
changed the title
mexisme
changed the title
mexisme
force-pushed
the
powershop/google-simpleauth
branch
2 times, most recently
from
01f380b to
e7f5230
Compare
mexisme
force-pushed
the
powershop/google-simpleauth
branch
from
92ab66f to
1834ce0
Compare
|
Apologies, @RISCfuture, I hadn't noticed the fixes in upstream, so had to merge them in. |
mexisme
force-pushed
the
powershop/google-simpleauth
branch
from
1834ce0 to
6d7f27a
Compare
|
Is there any reason for preferring the SimpleGoogleAuth here over Omniauth? |
At the time, SimpleGoogleAuth was what I'd used previously -- I've never needed to auth against other services, so haven't used OmniAuth. However, I'm afraid I'm no longer with PowerShop, so can't really provide further updates to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #117