Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback on events.md #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Enzo-Demeulenaere
Copy link
Contributor

Hi Renaud,

I do this PR to give you my feedback on your chapter, there's already so much content great job

I added some paragraphs/snippets for more details on specific points but these are my thoughts and they might need some checking or more in-depth understanding.
It appears you write about preventing mouseEvents twice during the chapter maybe the part in "event tips" is not so useful after you explained it in the "capturing phase"

I also have some questions about all this, I don't know if these are the type that you know the answer but I'd like to know your thoughts on it.

  • When talking about removing handlers, do you think we could maybe somehow "disable them" temporarily so if we want some behavior out for some time we wouldn't have to get a reference to the exact event handler, remove it and give it back later but maybe just have a flag 'disable' ?
  • When adding two event handlers on the same event for the same element, do you know if there's some kind of order in the processing ?
  • If I create a new custom handler class that deals with multiple events and that I add it dynamically a new event to handle, can I go back to the original state later by removing the new 'dynamically-added event' ? Does a reference to it suffice to remove it ?
  • Can we restrict shortcuts to react with a modifier and only this one ? for example If I check isAlt but I don't want cmd+shift+alt to react, do I need to specify isAlt and: isShift not and: isCmd not ?

Thank you for your chapter it will be really useful !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant