Issue #149: fixed bug in construction pattern DSDPS+DC. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. This change doesn't alter the slide deck of death. The bug was caused by a change in the slide (i.e., a planned change) being missed out at some point earlier this year. |
samuelsenior
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelsenior : the comments attached to issue #149 describe the tests I have run. I believe we now have enough test results to conclude that the fix corrects errors produced by the bug, and doesn't create new errors in a decent number of regressions tests.
Recommend you review and merge this one asap, so that you can merge from 6a back into your branch, since it will be affected by the bug.
Closes #149.