Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete check-catalog-info action as it can't be easily fixed #111

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

MaxymVlasov
Copy link
Contributor

@MaxymVlasov MaxymVlasov commented Oct 11, 2024

  1. GH actions doesn’t support public repos if we have internal runners pool. It’s due to security reasons to prevent a situation when someone uses our runners on his personal public repo. Risk of extra cost and eventual DOS

  2. Public workers will not be able to access spotoninc/github-action-validate-catalog-info@main, and we don't bother to fix it for this edge-case issue

GH actions doesn’t support public repos if we have internal runners pool. It’s due to security reasons to prevent a situation when someone uses our runners on his personal public repo. Risk of extra cost and eventual DOS
@MaxymVlasov MaxymVlasov requested a review from a team as a code owner October 11, 2024 13:19
@MaxymVlasov MaxymVlasov changed the title chore: fix check-catalog-info action chore: Fix check-catalog-info action Oct 11, 2024
@MaxymVlasov MaxymVlasov changed the title chore: Fix check-catalog-info action chore: Delete check-catalog-info action as it can't be easily fixed Oct 11, 2024
@MaxymVlasov MaxymVlasov merged commit c123c27 into main Oct 11, 2024
4 checks passed
@MaxymVlasov MaxymVlasov deleted the MaxymVlasov-patch-1 branch October 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants