Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deal with "File contents are invalid JSON but parse using JSON5" issue #100

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

burritoatspoton
Copy link
Contributor

@burritoatspoton burritoatspoton commented Jan 29, 2024

Put an x into the box if that applies:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Should fix Renovate warning:

WARN: File contents are invalid JSON but parse using JSON5. Support for this will be removed in a future release so please change to a support .json5 file name or ensure correct JSON syntax.

There might be a deeper issue with how default.json is autogenerated in https://github.com/SpotOnInc/renovate-config/blob/main/.github/workflows/generate-renovate-config.yaml#L22-L28 but this should be good enough for now.

How was it tested

@burritoatspoton burritoatspoton requested review from MaxymVlasov and a team as code owners January 29, 2024 09:10
@burritoatspoton burritoatspoton changed the title chore: fix default.json file format chore: Fix default.json file format Jan 29, 2024
@MaxymVlasov MaxymVlasov changed the title chore: Fix default.json file format fix: Deal with "File contents are invalid JSON but parse using JSON5" issue Jan 29, 2024
@MaxymVlasov MaxymVlasov merged commit f2f5e5b into main Jan 29, 2024
5 checks passed
@MaxymVlasov MaxymVlasov deleted the fix-default-json branch January 29, 2024 18:54
github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
## [2.2.1](v2.2.0...v2.2.1) (2024-01-29)

### Bug Fixes

* Deal with "File contents are invalid JSON but parse using JSON5" issue ([#100](#100)) ([f2f5e5b](f2f5e5b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants