Skip to content
This repository was archived by the owner on Nov 25, 2020. It is now read-only.

decorator @type #177

Closed
doktordirk opened this issue Jul 26, 2016 · 2 comments
Closed

decorator @type #177

doktordirk opened this issue Jul 26, 2016 · 2 comments
Labels
bug

Comments

@doktordirk
Copy link
Contributor

causes dirty checking of the property as it makes it non-configurable
@doktordirk doktordirk added the bug label Jul 26, 2016
@doktordirk
Copy link
Contributor Author

same seem to apply to all property decorators ie also to @asscociation

a simple fix is to add an @observable decorator to those properties as well. this adds the getter/setters to the property before for some reason 'configurable' gets set to false (which is the reason why aurelia can't auto-observe anymore and then uses dirty checking)

doktordirk added a commit to doktordirk/babel-plugin-transform-decorators-legacy that referenced this issue Aug 12, 2016
@doktordirk
fix(property-decorator): set configurable=true
6488495 
current version leaves the property non-configurable.this prevents aurelia from observing the property
see SpoonX/aurelia-orm#177
see aurelia/framework#541
@doktordirk doktordirk mentioned this issue Aug 12, 2016
Closed
@doktordirk
Copy link
Contributor Author

fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doktordirk