Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scaling for display entities #4111

Open
wants to merge 3 commits into
base: api-11
Choose a base branch
from

Conversation

DrZoddiak
Copy link
Contributor

Implements #setScale for Display Entities since they allow for scaling in 3 directions.

Copy link

@boxbeam boxbeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good

@avaruus1
Copy link
Contributor

avaruus1 commented Jul 15, 2024

How does this differ from setting the scale through the Transform or is it just a different way of doing the same thing?

@DrZoddiak
Copy link
Contributor Author

How does this differ from setting the scale through the Transform or is it just a different way of doing the same thing?

Effectively it's the same thing. Interpolation keys still effect the entity. This PR simply implements a method that already exists but has no implementation.

@Override
public Vector3d scale() {
return Vector3d.ONE;
}
@Override
public void setScale(final Vector3d scale) {
// do nothing, Minecraft doesn't properly support this yet
}

Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, and I'm good with merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants