-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement scaling for display entities #4111
base: api-11
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes good
How does this differ from setting the scale through the Transform or is it just a different way of doing the same thing? |
Effectively it's the same thing. Interpolation keys still effect the entity. This PR simply implements a method that already exists but has no implementation. Lines 147 to 155 in 994fb27
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, and I'm good with merging.
Implements
#setScale
for Display Entities since they allow for scaling in 3 directions.