Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarking currently requires workaround #49

Closed
psivesely opened this issue Mar 15, 2018 · 1 comment
Closed

Benchmarking currently requires workaround #49

psivesely opened this issue Mar 15, 2018 · 1 comment

Comments

@psivesely
Copy link
Contributor

cargo +nightly bench fails because benchmark files are trying to import modules not included in the library. I don't know how you'd like to address this, or else I'd make a PR. I've just been commenting out benches/{ss1,thss}.rs.
@romac
Copy link
Member

romac commented Mar 28, 2018

Oh right, I had forgotten to disable those until we merge the dss branch and actually release the DSS implementation.

@romac romac closed this as completed in 51f77fa Mar 28, 2018
romac added a commit that referenced this issue Aug 13, 2018
@romac
Disable dss benchmarks until we expose the module.
d098033 
Closes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romac @psivesely