Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dummy arguments to methods that don't really need them #916

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Add dummy arguments to methods that don't really need them #916

merged 1 commit into from
Jun 26, 2023

Conversation

dkfellows
Copy link
Member

Fixes #915

@dkfellows dkfellows added bug Something isn't working blocker Do not release when one of these is open! spalloc server Relating to the new spalloc server labels Jun 26, 2023
@dkfellows dkfellows added this to the 7.0.0 milestone Jun 26, 2023
@dkfellows dkfellows requested a review from rowleya June 26, 2023 13:18
@dkfellows dkfellows self-assigned this Jun 26, 2023
@dkfellows
Copy link
Member Author

I believe this to be a workaround for a weird Spring bug.

rowleya
rowleya approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd but it works!

@rowleya rowleya added this pull request to the merge queue Jun 26, 2023
Merged via the queue into master with commit a594942 Jun 26, 2023
@dkfellows dkfellows deleted the fix-null-args-in-spring branch June 26, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowleya rowleya rowleya approved these changes

Assignees

@dkfellows dkfellows

Labels
blocker Do not release when one of these is open! bug Something isn't working spalloc server Relating to the new spalloc server
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

NullPointerException when using the admin jsp pages
2 participants
@dkfellows @rowleya