Avoiding dinamically reading event list while processing #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the current method of checking changes on events won't work properly if an event is added at the same time as another is removed, because the list size stays the same and an event may be skipped. Probably my solution was not the most optimized, but it's how I made it work. To be more specific about the issue I faced, I had 5 events to be processed and the 3rd one removed itself and added another one, keeping the list with 5 elements but skipping the 4th element on the original list as it became the 3rd and the index jumped to the 4th without knowing the 3rd was replaced by an unprocessed event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the current method of checking changes on events won't work properly if an event is added at the same time as another is removed, because the list size stays the same and an event may be skipped. Probably my solution was not the most optimized, but it's how I made it work.
To be more specific about the issue I faced, I had 5 events to be processed and the 3rd one removed itself and added another one, keeping the list with 5 elements but skipping the 4th element on the original list as it became the 3rd and the index jumped to the 4th without knowing the 3rd was replaced by an unprocessed event.