Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken compilation, add m_virtualPlatinum #1

Closed
wants to merge 2 commits into from
Closed

Fix broken compilation, add m_virtualPlatinum #1

wants to merge 2 commits into from

Conversation

denizsokmen
Copy link
Collaborator

No description provided.

@coruja747
Copy link
Collaborator

Don't worry, m_virtualPlatinum got removed on last commit because it's now a virtual value. But it's not completely removed because it still needed on some functions. So instead set separately both gold / platinum values, now we store only the total value to later split it into gold (total % 1.000.000.000) and platinum (total / 1.000.000.000)

I'm rewriting the trade window code and this compiler error will be fixed in some minutes when I send it :D

@coruja747 coruja747 closed this Oct 8, 2015
@denizsokmen
Copy link
Collaborator Author

Okay :D

@lintax
Copy link
Member

lintax commented Oct 8, 2015

Actually having a build crushed for 10 hours in repository is a bad idea. Especially in master. The main reason why git is good - is almost no cost for branching... Your branch can consist of anything, however development one should be ok.
Best would be to apply patch that fixes the problem, and then make the proposed changes with the refactorings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants