CWorldTicker and other minor fixes. #1375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error in getting the length in bytes of strings containing non-ASCII characters. Refactored some CSQLite methods, for better reading.
… to use the RESDISPLAY_VERSION typedef. Renamed GetBaseID method, since it's doing something different than one would infer from the BASEID script property.
It should be faster and safer than before, also it should fix a possible bug with the previous ticking system. Also, made github workflows run on push on every branch, and added some ignored files.
|
Before merging it, i'd like to have different people to try this and have extensive tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the missing status updates issue.