Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name property to FieldV2 #28

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

mistermoe
Copy link
Contributor

This PR adds the name property to FieldV2.

Reference from the PEX V2 spec

image

also, just wanted to say thanks for all the hard work y'all have put into building and open sourcing the PEX libs! they've been really easy to use

@nklomp
Copy link
Contributor

nklomp commented Jul 10, 2023

Thanks for the PR. We indeed have more work to do n V2, simply because V1 still is the spec which has seen the most adoption (by far). Thanks for the nice words, we for sure will release a new major version pretty soon, making it even a bit nicer to work with.

@nklomp nklomp merged commit 8b2f1d7 into Sphereon-Opensource:master Jul 10, 2023
mistermoe added a commit to TBD54566975/tbdex that referenced this pull request Jul 12, 2023
mistermoe added a commit to TBD54566975/tbdex that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants