Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera config management #30

Merged
merged 22 commits into from
Oct 29, 2022
Merged

Camera config management #30

merged 22 commits into from
Oct 29, 2022

Conversation

Speykious
Copy link
Owner

This PR adds a way to enumerate all video input options for a camera device.

As of now, it only supports DShow and V4l2 input formats, but maybe more will be supported in the future.

  • DShow
  • VfWCap
  • GdiGrab
  • V4l2
  • X11Grab
  • AVFoundation
  • QTKit

I am not sure at all if other formats even need it... Until then, this is what we've got.

@Speykious Speykious force-pushed the camera-config-management branch from 57c2acb to 1a7b3be Compare October 29, 2022 00:37
@Speykious Speykious requested review from adryzz and removed request for adryzz October 29, 2022 00:51
@Speykious
Copy link
Owner Author

I tested camera configuration with OBS virtual camera and it works. Tomorrow I'll test with my real webcam.

Copy link
Collaborator

@adryzz adryzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i'll test it now

@adryzz
Copy link
Collaborator

adryzz commented Oct 29, 2022

image

It apparently is trying to use yuv420 while its name is yuv420p

Copy link
Collaborator

@adryzz adryzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now on YUV. LGTM.

@Speykious Speykious merged commit 040cb44 into main Oct 29, 2022
@Speykious Speykious deleted the camera-config-management branch October 29, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants