Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pre-built searches to avoid potentially comparing defined… #1139

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

urangel
Copy link
Contributor

@urangel urangel commented Feb 7, 2025

… types with null values

Description

The prebuilt search list has been updated so that we are not comparing potentially null values to defined types.

Motivation and Context

This PR addresses: BED-5415

Some of the queries are not working currently.

How Has This Been Tested?

The queries were executed manually in a test environment to check for any errors.
A test was added to find labels that deviate from our schema which catches typos in the hard coded query strings.

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@urangel urangel added bug Something isn't working user interface A pull request containing changes affecting the UI code. release blocker Must be completed before next release labels Feb 7, 2025
@urangel urangel self-assigned this Feb 7, 2025
Copy link
Contributor

@StephenHinck StephenHinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biggest issues were around the replacement of the previously hardcoded admin_tier_0 string with variable replacement, which still needs quotes. Others were questions about whether it's CySQL or direct syntax problems.

packages/javascript/bh-shared-ui/src/commonSearches.tsx Outdated Show resolved Hide resolved
packages/javascript/bh-shared-ui/src/commonSearches.tsx Outdated Show resolved Hide resolved
packages/javascript/bh-shared-ui/src/commonSearches.tsx Outdated Show resolved Hide resolved
packages/javascript/bh-shared-ui/src/commonSearches.tsx Outdated Show resolved Hide resolved
packages/javascript/bh-shared-ui/src/commonSearches.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@StephenHinck StephenHinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check the two questions around CySQL, but presuming those are CySQL related, this looks good!

@urangel urangel merged commit 889316f into stage/v7.0.1 Feb 11, 2025
6 checks passed
@urangel urangel deleted the BED-5415 branch February 11, 2025 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working release blocker Must be completed before next release user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants