-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update pre-built searches to avoid potentially comparing defined… #1139
Conversation
… types with null values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Biggest issues were around the replacement of the previously hardcoded admin_tier_0
string with variable replacement, which still needs quotes. Others were questions about whether it's CySQL or direct syntax problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double-check the two questions around CySQL, but presuming those are CySQL related, this looks good!
… types with null values
Description
The prebuilt search list has been updated so that we are not comparing potentially null values to defined types.
Motivation and Context
This PR addresses: BED-5415
Some of the queries are not working currently.
How Has This Been Tested?
The queries were executed manually in a test environment to check for any errors.
A test was added to find labels that deviate from our schema which catches typos in the hard coded query strings.
Screenshots (optional):
Types of changes
Checklist: